-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: amdgpu-pro update #29698
wip: amdgpu-pro update #29698
Conversation
error: syntax error, unexpected ')', expecting ';', at [...]/nixpkgs/pkgs/os-specific/linux/amdgpu-pro/default.nix:63:4 I don't know how to send you the correct version, via git here, so I guess it's easier if you fix that simple yourself. |
861a67a
to
3375300
Compare
Thanks, fixed. So far I've tested:
I haven't got around to testing the 32-bit stuff, opencl, or vulkan, so if you verify any of those, let me know. Make sure you are using the custom 4.10 kernel it provides. It won't work without |
An error message I got during installation
I don't know if it's important but I thought I paste it here before rebooting. |
I could verify that vulkan works on 32Bit and 64Bit and opengl works on 32Bit. |
3375300
to
5b2235b
Compare
@pstn Any problems so far? |
Bad performance in a few applications but I don't think that it's anything to concern us with because it seems to happen in all distributions with my hardware.
|
I have no idea how to test opencl. So I tried:
So I guess there is something wrong there. Other than that I didn't encounter anything that would prohibit a merge. |
@@ -31,17 +35,25 @@ in | |||
|
|||
boot.extraModulePackages = [ package ]; | |||
|
|||
boot.kernelPackages = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vcunat What do you think of this? It feels wrong, but this kernel module requires linux 4.10 w/ KALLSYMS_ALL=y
, and I couldn't find a precedent for influencing the kernel config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, 4.10 branch was killed upstream, and we already deleted it in nixpkgs as well. Second, just the fact of users having to build their own kernel would be quite a nuisance. Perhaps it would be good to look into the suitability of having the option in default kernels (say those > 4.9).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.13 is the only maintained branch newer than 4.9 ATM (4.9 is the latest longterm branch).
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)